Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement error.type attribute in HTTP semconv #9466

Merged
merged 5 commits into from
Oct 10, 2023

Conversation

mateuszrzeszutek
Copy link
Member

@mateuszrzeszutek mateuszrzeszutek commented Sep 14, 2023

Resolves #9438
Part of #9090

@mateuszrzeszutek mateuszrzeszutek marked this pull request as ready for review September 18, 2023 10:20
@mateuszrzeszutek mateuszrzeszutek requested a review from a team September 18, 2023 10:20
* cancelled}, {@code _OTHER}.
*/
@Nullable
default String getErrorType(
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought about creating a separate extractor just for that, but decided against it -- let's first see if there are any other use cases for this attribute, and we can retroactively implement a new getter interface if there's a need to do so.

@mateuszrzeszutek
Copy link
Member Author

@trask is there anything else blocking this PR?

@trask trask added this to the v1.31.0 milestone Oct 10, 2023
Copy link
Member

@trask trask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx!

@trask trask merged commit b6dd11a into open-telemetry:main Oct 10, 2023
46 of 47 checks passed
@mateuszrzeszutek mateuszrzeszutek deleted the error-type branch October 11, 2023 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement error.type attribute
3 participants