Replace (client|server).socket.(address|port) attributes with network.(peer|local).(address|port)
#9676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mateuszrzeszutek
force-pushed
the
network-peer-local
branch
from
4eba6f3
to
e978372
Compare
laurit
approved these changes
Oct 16, 2023
mateuszrzeszutek
force-pushed
the
network-peer-local
branch
from
e06e453
to
8338a92
Compare
trask
approved these changes
Oct 17, 2023
|
@mateuszrzeszutek sorry probably I should have merged this one first |
|
No worries, I'll manage the merge -- all the conflicts are made by me after all 😄 |
added 9 commits
October 18, 2023 10:43
….(peer|local).(address|port)
mateuszrzeszutek
force-pushed
the
network-peer-local
branch
from
0e87d13
to
ec31384
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements open-telemetry/semantic-conventions#342; or at least part of it, I'll deprecate the
get(Client|Server)Socket*methods in another PR