Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't normalize the '-' character in HTTP header names #9735

Merged
merged 5 commits into from
Oct 24, 2023

Conversation

mateuszrzeszutek
Copy link
Member

@mateuszrzeszutek mateuszrzeszutek requested a review from a team October 23, 2023 08:56
Copy link
Contributor

@laurit laurit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mateuszrzeszutek
Copy link
Member Author

I'll make the same change for the server parameters feature; the messaging headers will need to be changed anyway when we start working on the messaging semconv.

@trask trask merged commit 8bc5297 into open-telemetry:main Oct 24, 2023
47 checks passed
@mateuszrzeszutek mateuszrzeszutek deleted the dont-normalize-dashes branch October 26, 2023 08:18
Abhishekkr3003 pushed a commit to Abhishekkr3003/opentelemetry-java-instrumentation that referenced this pull request Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants