Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Status object from API, keep StatusCanonicalCode #1741

Merged
merged 3 commits into from
Oct 5, 2020

Conversation

bogdandrutu
Copy link
Member

Signed-off-by: Bogdan Drutu bogdandrutu@gmail.com

@bogdandrutu bogdandrutu changed the title WIP: Remove Status object from API, keep StatusCanonicalCode Remove Status object from API, keep StatusCanonicalCode Oct 4, 2020
@codecov
Copy link

codecov bot commented Oct 4, 2020

Codecov Report

Merging #1741 into master will decrease coverage by 0.09%.
The diff coverage is 70.96%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1741      +/-   ##
============================================
- Coverage     85.27%   85.17%   -0.10%     
+ Complexity     1363     1351      -12     
============================================
  Files           164      166       +2     
  Lines          5298     5276      -22     
  Branches        551      549       -2     
============================================
- Hits           4518     4494      -24     
+ Misses          579      578       -1     
- Partials        201      204       +3     
Impacted Files Coverage Δ Complexity Δ
api/src/main/java/io/opentelemetry/trace/Span.java 100.00% <ø> (ø) 1.00 <0.00> (ø)
...opentelemetry/opentracingshim/SpanBuilderShim.java 54.63% <0.00%> (ø) 22.00 <0.00> (ø)
...n/java/io/opentelemetry/sdk/trace/SpanWrapper.java 100.00% <ø> (ø) 22.00 <0.00> (ø)
...java/io/opentelemetry/sdk/trace/data/SpanData.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...ava/io/opentelemetry/opentracingshim/SpanShim.java 44.11% <25.00%> (ø) 14.00 <0.00> (ø)
...ntelemetry/sdk/trace/RecordEventsReadableSpan.java 79.90% <66.66%> (ø) 65.00 <3.00> (ø)
.../opentelemetry/sdk/trace/data/ImmutableStatus.java 77.77% <77.77%> (ø) 5.00 <5.00> (?)
.../main/java/io/opentelemetry/trace/DefaultSpan.java 79.16% <100.00%> (ø) 17.00 <1.00> (ø)
...va/io/opentelemetry/trace/StatusCanonicalCode.java 100.00% <100.00%> (ø) 3.00 <3.00> (?)
...a/io/opentelemetry/exporters/otlp/SpanAdapter.java 95.95% <100.00%> (ø) 20.00 <0.00> (ø)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 50a8fbf...67d7e1a. Read the comment docs.

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
Copy link
Contributor

@anuraaga anuraaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@anuraaga anuraaga merged commit eb4a18f into open-telemetry:master Oct 5, 2020
@bogdandrutu bogdandrutu deleted the immutablestatus branch October 5, 2020 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants