Remove Status.value #2147
Merged
Remove Status.value #2147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anuraaga
requested review from
arminru,
bogdandrutu,
carlosalberto,
jkwatson,
Oberon00,
pavolloffay,
thisthat and
tylerbenson
as code owners
|
This PR also changes attribute names in the Jaeger exporter. Intentionally? |
|
Yeah went ahead and reflected the almost merged open-telemetry/opentelemetry-specification#1257 since it makes clearest what to do instead of using value. We can hold off on merging this until that's in of course. |
jkwatson
reviewed
Nov 30, 2020
| * | ||
| * @return the numerical value of the code. | ||
| */ | ||
| public int value() { |
There was a problem hiding this comment.
since this is a public API should we deprecate it before deleting?
added 2 commits
December 1, 2020 13:23
… into remove-status-value
Codecov Report
@@ Coverage Diff @@
## master #2147 +/- ##
============================================
- Coverage 85.33% 85.29% -0.04%
- Complexity 2135 2136 +1
============================================
Files 245 245
Lines 8181 8181
Branches 903 904 +1
============================================
- Hits 6981 6978 -3
- Misses 869 874 +5
+ Partials 331 329 -2
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1744
Not quite merged but open-telemetry/opentelemetry-specification#1257 has so many approvals I just went with its spec.