Update the semconv to spec v1.4.0 #3298
Conversation
jkwatson
requested review from
anuraaga,
arminru,
bogdandrutu,
carlosalberto,
Oberon00,
pavolloffay,
thisthat and
tylerbenson
as code owners
|
@jkwatson Any thoughts on releasing SDK 1.3.0 before this or doesn't matter at all? Since we're planning to anyways, it allows the versions to be aligned for a bit more. |
I'm fine either way. We're always going to be at least one minor version behind the spec (and even if we merge this, there is still the schema stuff to get in). |
| * being called. Useful for client-side traces since client does not know what will be called on | ||
| * the server. | ||
| */ | ||
| public static final AttributeKey<String> RPC_JSONRPC_METHOD = stringKey("rpc.jsonrpc.method"); |
There was a problem hiding this comment.
That new attribute is a bit unfortunate, I opened a spec PR: open-telemetry/opentelemetry-specification#1748 to remove it / clarify that rpc.method can be used instead.
There was a problem hiding this comment.
@Oberon00 do you think we should just wait for that to settle before merging this, then?
There was a problem hiding this comment.
IMHO it's better to have this one potentially bad attribute than not to update at all. The module is alpha anyway.
There was a problem hiding this comment.
I just cut the 1.3.0 release, so we'll get what we get in the next version. :)
No description provided.