Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(exporter-collector): CollectorTransportNode should be CollectorProtocolNode #1432

Merged
merged 2 commits into from
Aug 20, 2020
Merged

Conversation

hongbo-miao
Copy link
Contributor

@hongbo-miao hongbo-miao commented Aug 16, 2020

Which problem is this PR solving?

  • The API in the doc is wrong.

Short description of the changes

  • When I try to use latest @opentelemetry/exporter-collector version 0.10.2, I believe the current correct API is CollectorProtocolNode instead of CollectorTransportNode.

If you search CollectorTransportNode in the source code of this repo, there is no such thing actually.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Aug 16, 2020

CLA Check
The committers are authorized under a signed CLA.

@codecov
Copy link

codecov bot commented Aug 16, 2020

Codecov Report

Merging #1432 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1432   +/-   ##
=======================================
  Coverage   93.89%   93.89%           
=======================================
  Files         148      148           
  Lines        4393     4393           
  Branches      894      894           
=======================================
  Hits         4125     4125           
  Misses        268      268           

@hongbo-miao hongbo-miao changed the title docs(exporter-collector): change CollectorTransportNode to CollectorProtocolNode docs(exporter-collector): CollectorTransportNode should be CollectorProtocolNode Aug 18, 2020
@dyladan dyladan added the document Documentation-related label Aug 20, 2020
@dyladan dyladan merged commit a3357d5 into open-telemetry:master Aug 20, 2020
@hongbo-miao hongbo-miao deleted the patch-1 branch August 20, 2020 18:09
pichlermarc pushed a commit to dynatrace-oss-contrib/opentelemetry-js that referenced this pull request Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
document Documentation-related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants