Update HTTP client span semconv to 1.27 #4940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
dyladan
commented
Aug 23, 2024
| import { errorMonitor } from 'events'; | ||
| import { SEMATTRS_HTTP_ROUTE } from '@opentelemetry/semantic-conventions'; | ||
| import { |
There was a problem hiding this comment.
removed import *. None of these imports are actually new
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4940 +/- ##
==========================================
- Coverage 93.29% 91.04% -2.26%
==========================================
Files 84 88 +4
Lines 1700 1954 +254
Branches 349 416 +67
==========================================
+ Hits 1586 1779 +193
- Misses 114 175 +61 |
pichlermarc
reviewed
Aug 28, 2024
experimental/packages/opentelemetry-instrumentation-http/README.md
Outdated
Show resolved
Hide resolved
experimental/packages/opentelemetry-instrumentation-http/README.md
Outdated
Show resolved
Hide resolved
experimental/packages/opentelemetry-instrumentation-http/src/utils.ts
Outdated
Show resolved
Hide resolved
experimental/packages/opentelemetry-instrumentation-http/test/functionals/http-enable.test.ts
Outdated
Show resolved
Hide resolved
experimental/packages/opentelemetry-instrumentation-http/test/functionals/utils.test.ts
Outdated
Show resolved
Hide resolved
experimental/packages/opentelemetry-instrumentation-http/src/utils.ts
Outdated
Show resolved
Hide resolved
…tils.ts Co-authored-by: Marc Pichler <marcpi@edu.aau.at>
Co-authored-by: Mend Renovate <bot@renovateapp.com>
pichlermarc
approved these changes
Sep 4, 2024
pichlermarc
reviewed
Sep 4, 2024
pichlermarc
approved these changes
Sep 4, 2024
MSNev
approved these changes
Sep 4, 2024
AbhiPrasad
pushed a commit
to getsentry/sentry-javascript
that referenced
this pull request
Sep 9, 2024
…cing (#13485) This PR migrates the `nativeNodeFetchIntegration` to use `@opentelemetry/instrumentation-undici` instead of `opentelemetry-instrumentation-fetch-node`. The instrumentation is still exported as `nativeNodeFetchIntegration` and is named `NodeFetch` to ensure backwards compatibility and the tests pass ~~without changes~~. Note: One `nextjs-14` e2e test did need a change due to the new/differing attribute names. It's worth noting that `@opentelemetry/instrumentation-undici` [uses different attributes](open-telemetry/opentelemetry-js-contrib#2417 (comment)) from the latest semantic convention version vs what we are using and what's used by `opentelemetry-instrumentation-fetch-node`. It looks like the [http instrumentation is migrating to these too](open-telemetry/opentelemetry-js#4940) so some of the changes in this PR will ensure that the http instrumentation continues to work after these updates.
Zirak
pushed a commit
to Zirak/opentelemetry-js
that referenced
this pull request
Sep 14, 2024
Co-authored-by: Marc Pichler <marcpi@edu.aau.at> Co-authored-by: Mend Renovate <bot@renovateapp.com> Co-authored-by: Marc Pichler <marc.pichler@dynatrace.com>
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the HTTP client semantic conventions to 1.27.
Client metrics and server spans and metrics to be done in follow-up PRs.