Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate the code using gogofaster and the grpc plugin #40

Closed
wants to merge 1 commit into from
Closed

Generate the code using gogofaster and the grpc plugin #40

wants to merge 1 commit into from

Conversation

dmathieu
Copy link
Member

@dmathieu dmathieu commented Feb 15, 2022

This changes the generation command so it uses gogofaster_out, as well as the gRPC plugin for all proto files.

Doing so generates the Unmarshal method for service payloads, which is required to unmarshal protobuf data send through an HTTP endpoint (which someone wishing to implement an OTLP endpoint through HTTP will have to do).

This change should also make it possible to use this repository within the collector instead of the current submodule.

Note: I didn't commit the regenerated code, because the license header gets dropped. So I suppose something, but I didn't see anything about it in RELEASING.md.

@dmathieu dmathieu requested a review from a team February 15, 2022 09:02
@MadVikingGod
Copy link
Contributor

The collector is actively moving away from gogo: open-telemetry/opentelemetry-collector#4258

@dmathieu dmathieu closed this Feb 16, 2022
@dmathieu dmathieu deleted the gogofaster-grpc branch February 16, 2022 10:18
@bogdandrutu
Copy link
Member

@MadVikingGod we are not actively moving away, we are looking into options :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants