Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metric instrumentation falcon #1230

Merged

Conversation

TheAnshul756
Copy link
Contributor

Description

Fixes #1157

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

  • tox -e test-instrumentation-falcon1
  • tox -e test-instrumentation-falcon2
  • tox -e test-instrumentation-falcon3

Does This PR Require a Core Repo Change?

  • No.

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added

@TheAnshul756 TheAnshul756 requested a review from a team August 16, 2022 06:38
@lzchen
Copy link
Contributor

lzchen commented Aug 30, 2022

Please update the readme

Copy link
Member

@srikanthccv srikanthccv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM. Added minor comment about the start marker in two places.

@srikanthccv srikanthccv enabled auto-merge (squash) September 22, 2022 08:41
@srikanthccv srikanthccv merged commit 9a2285a into open-telemetry:main Sep 22, 2022
@TheAnshul756 TheAnshul756 deleted the metric-instrumentation-falcon branch September 22, 2022 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Metrics instrumentation falcon
4 participants