Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix check of is_otel_instrumented #1313

Merged

Conversation

TheAnshul756
Copy link
Contributor

@TheAnshul756 TheAnshul756 commented Sep 2, 2022

Fixes #1312

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • tox -e test-instrumentation-fastapi

Does This PR Require a Core Repo Change?

  • No.

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added

@TheAnshul756 TheAnshul756 requested a review from a team September 2, 2022 08:56
@lzchen lzchen merged commit 4c23823 into open-telemetry:main Sep 9, 2022
@TheAnshul756 TheAnshul756 deleted the fix-fastapi-otel-instrumented-check branch September 9, 2022 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

is_instrumented_by_opentelemetry is not set in _InstrumentedFastAPI class
3 participants