Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add grpc.aio instrumentation to be auto-instrumented #1442

Merged
merged 6 commits into from
Nov 22, 2022

Conversation

cookiefission
Copy link
Contributor

Description

PR #1245 added grpc.aio instrumentation. It included the auto instrumentor for grpc.aio but did not include the entry-points hook for it to be run automatically on boot.

Currently, you need to manually include the instrumentor and call it. This makes that automatic and in line with the plain grpc instrumentation.

Fixes no-issue (but can raise one if needed)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

It hasn't been tested because I'm unsure how. I'd presumably need to build a dev version and package it to an app but given the simplicity of the change, I'm hoping it's fine.

Does This PR Require a Core Repo Change?

  • Yes. - Link to PR:
  • No.

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

PR open-telemetry#1245 added grpc.aio instrumentation. It included the auto
instrumentor for grpc.aio but did not include the entry-points hook for
it to be run automatically on boot.

Currently, you need to manually include the instrumentor and call it.
This makes that automatic and in line with the plain grpc
instrumentation.
@cookiefission cookiefission requested a review from a team November 15, 2022 14:39
@lzchen lzchen enabled auto-merge (squash) November 22, 2022 02:53
@lzchen lzchen merged commit 80d0b89 into open-telemetry:main Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants