Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AWS X-Ray Ids Generator Entry Point #201

Merged

Conversation

NathanielRN
Copy link
Contributor

Description

In response to open-telemetry/opentelemetry-python#1404, it is convenient to be able to auto instrument the AWS SDK Extension by adding AwsXrayIdsGenerator as an entry point.

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

A test in open-telemetry/opentelemetry-python#1404 covers using an environment variable to find and set a CustomIdsGenerator.

Does This PR Require a Core Repo Change?

  • No.

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

  • Followed the style guidelines of this project
  • Changelogs have been updated
    - [ ] Unit tests have been added
    - [ ] Documentation has been updated

@NathanielRN NathanielRN requested review from a team, toumorokoshi and ocelotl and removed request for a team November 21, 2020 17:09
@codeboten codeboten merged commit 9334eef into open-telemetry:master Nov 23, 2020
@NathanielRN NathanielRN deleted the ids-generator-entry-point branch November 25, 2020 18:13
AzfaarQureshi pushed a commit to open-o11y/opentelemetry-python-contrib that referenced this pull request Nov 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants