Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTP transition for flask and wsgi #2024

Closed
wants to merge 4 commits into from

Conversation

lmolkova
Copy link
Contributor

Built on top of #1987

Server part of #1986

Changes and observations :

  • For the 'old' default mode:
    • removes alternative attribute sets for host/url, unifying everything to net.host.name, net.host.port
    • fixes some minor bugs (span name, unknown HTTP method names)
  • Implements new "http" and "http/dup" modes

Didn't see any technical challenges or limitations when implementing the new version of spec (except tons of boilerplate code)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants