-
Notifications
You must be signed in to change notification settings - Fork 583
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more tests, fix compliance to semantics #236
Commits on Dec 10, 2020
-
Update gRPC instrumentation to comply with spec
For open-telemetry#139 - some of these things weren't as clear before.
Michael Stella committedDec 10, 2020 Configuration menu - View commit details
-
Copy full SHA for 7271cde - Browse repository at this point
Copy the full SHA 7271cdeView commit details -
Update tests to use proper handler names
In the real world, the interceptor is always going to be passed a HandlerCallDetails object with the `method` field set to something valid... previously these tests set this to an empty string, but that's not what happens in a real case. So I've updated the tests to do that right, but also made sure that the span processing allows this to be unset, just in case someone was expecting this behavior to be present.
Michael Stella committedDec 10, 2020 Configuration menu - View commit details
-
Copy full SHA for 3ca5376 - Browse repository at this point
Copy the full SHA 3ca5376View commit details -
Check span attributes, fix errors
Now checking the span attributes we've added in the Interceptor. Also fixed some cut & paste errors that resulted in not verifying all spans as intended.
Michael Stella committedDec 10, 2020 Configuration menu - View commit details
-
Copy full SHA for e70d4b6 - Browse repository at this point
Copy the full SHA e70d4b6View commit details -
Abort test, clarified attributes
Added a test for handling gRPC aborts, which was previously missing. Updated the `net.*` attributes, so that `net.peer.ip` is always set, and `net.peer.name` is set only if it's `localhost`, since otherwise we'd need to do DNS lookups, and the spec doesn't require that. Added tests to verify the `net.*` shows up properly.
Michael Stella committedDec 10, 2020 Configuration menu - View commit details
-
Copy full SHA for 8bf21fe - Browse repository at this point
Copy the full SHA 8bf21feView commit details -
I always forget to run Black on this repo.
Michael Stella committedDec 10, 2020 Configuration menu - View commit details
-
Copy full SHA for f3c6083 - Browse repository at this point
Copy the full SHA f3c6083View commit details -
Apparently I need to run black twice?
Michael Stella committedDec 10, 2020 Configuration menu - View commit details
-
Copy full SHA for 5bd8fad - Browse repository at this point
Copy the full SHA 5bd8fadView commit details -
Michael Stella committed
Dec 10, 2020 Configuration menu - View commit details
-
Copy full SHA for 30b68bf - Browse repository at this point
Copy the full SHA 30b68bfView commit details -
Format span error description properly
Michael Stella committedDec 10, 2020 Configuration menu - View commit details
-
Copy full SHA for 213682e - Browse repository at this point
Copy the full SHA 213682eView commit details -
This is why we now have tests, right?
It's really nice to have tests to catch this stuff now.
Michael Stella committedDec 10, 2020 Configuration menu - View commit details
-
Copy full SHA for f3abdbc - Browse repository at this point
Copy the full SHA f3abdbcView commit details -
Michael Stella committed
Dec 10, 2020 Configuration menu - View commit details
-
Copy full SHA for 72b58bc - Browse repository at this point
Copy the full SHA 72b58bcView commit details