Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added recording of exceptions in Pyramid #2622

Merged
merged 5 commits into from
Jun 20, 2024
Merged

Conversation

rbagd
Copy link
Contributor

@rbagd rbagd commented Jun 19, 2024

Description

This PR adapts the instrumentation of Pyramid applications so that traces would contain information on uncaught exceptions or errors while serving a request. This is similar to what is done in the generic OpenTelemetryMiddleware for WSGI apps, which is not used in Pyramid instrumentation.

Fixes #2619

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Unit tests added to ensure information on exceptions is present in generated traces. Only HTTP 5xx-like responses should generate such exceptions.

Does This PR Require a Core Repo Change?

  • No.

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

* Only internal errors and exceptions are recorded
* Status description is updated in case of an error
* Unit tests added
@rbagd rbagd requested a review from a team June 19, 2024 16:38
@rbagd rbagd mentioned this pull request Jun 19, 2024
1 task
Copy link
Contributor

@xrmx xrmx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@lzchen lzchen merged commit fecb1e2 into open-telemetry:main Jun 20, 2024
365 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exceptions are not recorded in traces from instrumented Pyramid apps
3 participants