Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confluent Kafka: Ensure consume span is ended when consumer is closed #2640

Merged

Conversation

joshschltelus
Copy link
Contributor

@joshschltelus joshschltelus commented Jun 26, 2024

Description

Fix an issue with the confluent kafka instrumentation where the consume span created after a message is received is not closed when the consumer is closed

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Added a unit test for close and tested with

tox -e py310-test-instrumentation-confluent-kafka

Does This PR Require a Core Repo Change?

  • No.

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@joshschltelus joshschltelus changed the title Confluent Kafka: Consume span is not ended when consumer is closed Confluent Kafka: Ensure consume span is ended when consumer is closed Jun 26, 2024
@joshschltelus joshschltelus requested a review from a team June 26, 2024 21:03
Copy link
Contributor

@xrmx xrmx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a kafka expert but what is doing is similar to what is already done for other methods so LGTM

@lzchen lzchen merged commit df3415b into open-telemetry:main Jul 2, 2024
365 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants