Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove 'component' span attribute in instrumentations #301

Merged
merged 5 commits into from
Jan 29, 2021

Conversation

mariojonke
Copy link
Contributor

@mariojonke mariojonke commented Jan 27, 2021

Description

Fixes #300

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Does This PR Require a Core Repo Change?

  • No.

Checklist:

  • Followed the style guidelines of this project
  • Changelogs have been updated

@mariojonke mariojonke requested review from a team, toumorokoshi and lzchen and removed request for a team January 27, 2021 12:33
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR looks great, just one question regarding whether database_type should be removed as well.

database_component: Database driver name or database name "JDBI",
"jdbc", "odbc", "postgreSQL".
database_system: An identifier for the database management system (DBMS)
product being used.
database_type: The Database type. For any SQL database, "sql".
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should database_type be removed? i couldn't find it in the semantic conventions for databases

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes looks like there are no semantic convetions for it. It also doesn't seem to be used anywhere in the code so i'll remove it.

Base automatically changed from master to main January 29, 2021 19:28
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing my comments!

@lzchen lzchen merged commit f0adb23 into open-telemetry:main Jan 29, 2021
@mariojonke mariojonke deleted the remove-component-semconv-attr branch April 13, 2021 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove 'component' span attribute in instrumentations
5 participants