Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update datadog exporter error tagging #459

Merged

Conversation

ericmustin
Copy link
Contributor

@ericmustin ericmustin commented Apr 19, 2021

Description

Fixes #244(#244). I think this is ready for review, pretty straightforward, when span status is not ok we iterate over events and look for exception info.

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Updated Unit Tests

Does This PR Require a Core Repo Change?

  • Yes. - Link to PR:
  • No.

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@ericmustin ericmustin requested review from a team, aabmass and hectorhdzg and removed request for a team April 19, 2021 20:47
@ericmustin ericmustin changed the title [WIP] Update datadog exporter error tagging Update datadog exporter error tagging Apr 19, 2021
@ericmustin
Copy link
Contributor Author

cc @majorgreys @alertedsnake @codeboten reviews welcome! cheers

Copy link
Contributor

@majorgreys majorgreys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the existing test sufficient to test the new event exception extraction?

@ericmustin
Copy link
Contributor Author

ericmustin commented Apr 22, 2021

@majorgreys I think so? our existing test raises an error with start_span, which ensures span.record_exception gets called and adds an exception event. See here. I updated the test to ensure all 3 relevant tags for datadog errors are getting extracted.

@majorgreys
Copy link
Contributor

majorgreys commented Apr 22, 2021

@ericmustin Thanks! Should a test be added for the fallback? Is there any scenario where this fallback is necessary?

@ericmustin
Copy link
Contributor Author

ericmustin commented Apr 22, 2021

@majorgreys yea im not sure, i think let's just remove the old fallback approach, in practice we should never need it now, will update

Copy link
Contributor

@alertedsnake alertedsnake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thanks @ericmustin! I'm glad you got a chance to work on it before I could :)

@lzchen
Copy link
Contributor

lzchen commented Apr 27, 2021

@majorgreys
Have your questions been answered?

@lzchen lzchen merged commit 45c94e7 into open-telemetry:main Apr 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Datadog exporter shouldn't parse span description to determine if there was an exception
5 participants