Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary deps on test pkgs #752

Merged

Conversation

NathanielRN
Copy link
Contributor

@NathanielRN NathanielRN commented Oct 18, 2021

Description

We just found out that the opentelemetry-sdk-extension-aws and opentelemetry-propagator-aws-xray packages do not need to depend on the opentelemetry-test package.

We remove their dependencies in this PR.

Since it is removing a dependency and not adding one, we can release these packages as _patch` updates.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • This change requires a documentation update

How Has This Been Tested?

  • Made a new virtual environment
  • Cloned the contrib repo
  • Removed the dependencies on opentelemetry-test
  • Ran both tox -e test-sdkextensionaws and tox -e test-propagator-aws
  • Saw that they both ran successfully

Does This PR Require a Core Repo Change?

  • No.

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

  • Followed the style guidelines of this project
  • Changelogs have been updated
    - [] Unit tests have been added
  • Documentation has been updated

@NathanielRN NathanielRN requested a review from a team October 18, 2021 19:25
@NathanielRN NathanielRN force-pushed the remove-unnecessary-deps-on-test branch from 29b3f8d to 77a74a8 Compare October 18, 2021 19:27
@lzchen lzchen enabled auto-merge (squash) October 18, 2021 19:38
@lzchen lzchen merged commit c6ec486 into open-telemetry:main Oct 18, 2021
@NathanielRN NathanielRN deleted the remove-unnecessary-deps-on-test branch October 18, 2021 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants