Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a logic bug on parentless spans #782

Merged
merged 9 commits into from
Nov 19, 2021

Conversation

tonybaloney
Copy link
Contributor

Fixes #771

@tonybaloney tonybaloney requested a review from a team October 26, 2021 22:19
@ocelotl
Copy link
Contributor

ocelotl commented Oct 27, 2021

@tonybaloney please add a test case for this fix ✌️

@tonybaloney
Copy link
Contributor Author

Added a simple test, any pointers for useful test examples would be welcome. I looked at data dog, but its really complicated!

@owais
Copy link
Contributor

owais commented Nov 18, 2021

@tonybaloney please add a changelog entry

@tonybaloney
Copy link
Contributor Author

@tonybaloney please add a changelog entry

done

@owais owais merged commit f0ac738 into open-telemetry:main Nov 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug in RichConsoleSpanExporter
4 participants