Add support for generic OTEL_PYTHON_EXCLUDED_URLS variable #790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamantike
force-pushed
the
add-OTEL_PYTHON_EXCLUDED_URLS
branch
from
2698849
to
f0a3bce
Compare
owais
reviewed
Nov 2, 2021
util/opentelemetry-util-http/src/opentelemetry/util/http/__init__.py
Outdated
Show resolved
Hide resolved
srikanthccv
reviewed
Nov 4, 2021
| @@ -32,7 +32,8 @@ | |||
|
|
|||
| Exclude lists | |||
| ************* | |||
| To exclude certain URLs from being tracked, set the environment variable ``OTEL_PYTHON_DJANGO_EXCLUDED_URLS`` with comma delimited regexes representing which URLs to exclude. | |||
| To exclude certain URLs from being tracked, set the environment variable ``OTEL_PYTHON_EXCLUDED_URLS`` or ``OTEL_PYTHON_DJANGO_EXCLUDED_URLS`` | |||
| with comma delimited regexes representing which URLs to exclude. | |||
There was a problem hiding this comment.
Maybe mention the precedence when both are set?
There was a problem hiding this comment.
Would this wording make that clear, or should we go with a different one?
To exclude certain URLs from being tracked, set the environment variable
OTEL_PYTHON_{instrumentation}_EXCLUDED_URLS(orOTEL_PYTHON_EXCLUDED_URLSas fallback) with comma delimited regexes representing which URLs to exclude.
There was a problem hiding this comment.
@lonewolf3739 please resolve if you are satisfied with the change. thanks
srikanthccv
approved these changes
Nov 4, 2021
owais
approved these changes
Nov 4, 2021
lzchen
approved these changes
Nov 8, 2021
|
@adamantike please resolve conflicts so that we can merge ✌️ |
Use `OTEL_PYTHON_EXCLUDED_URLS` environment variable as a fallback of
`OTEL_PYTHON_{instrumentation}_EXCLUDED_URLS`.
auto-merge was automatically disabled
November 9, 2021 15:25
Head branch was pushed to by a user without write access
adamantike
force-pushed
the
add-OTEL_PYTHON_EXCLUDED_URLS
branch
from
de7ce9d
to
74c366d
Compare
|
Rebased, and changed docs wording. Let me know if that's clear enough! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use
OTEL_PYTHON_EXCLUDED_URLSenvironment variable as a fallback ofOTEL_PYTHON_{instrumentation}_EXCLUDED_URLS.Fixes #789
Type of change
How Has This Been Tested?
tox -e test-util-httpDoes This PR Require a Core Repo Change?
Checklist: