Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aiohttp instrumentation: correct url filter input type #864

Merged
merged 8 commits into from
Feb 1, 2022
Merged

aiohttp instrumentation: correct url filter input type #864

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
58e4da3
fix: correct _UrlFilterT
Olegt0rr Jan 14, 2022
9d2bfc7
docs: CHANGELOG.md update
Olegt0rr Jan 15, 2022
eed2bef
Merge branch 'main' into fix-url-typing
Olegt0rr Feb 1, 2022
69e5ccf
style: apply isort
Olegt0rr Feb 1, 2022
e482ba5
fix: add yarl to docs requirements
Olegt0rr Feb 1, 2022
00a125d
Revert "fix: add yarl to docs requirements"
Olegt0rr Feb 1, 2022
f817af6
fix: add yarl to nitpick exceptions
Olegt0rr Feb 1, 2022
ad3b505
Merge branch 'main' into fix-url-typing
ocelotl Feb 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- `opentelemetry-instrumentation-asgi` ASGI: Conditionally create SERVER spans
([#843](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/843))

- `opentelemetry-instrumentation-aiohttp-client` aiohttp: Correct url filter input type
([#843](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/864))


## [1.8.0-0.27b0](https://github.com/open-telemetry/opentelemetry-python/releases/tag/v1.8.0-0.27b0) - 2021-12-17

Expand Down
4 changes: 2 additions & 2 deletions ...strumentation-aiohttp-client/src/opentelemetry/instrumentation/aiohttp_client/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ def response_hook(span: Span, params: typing.Union[

import aiohttp
import wrapt

import yarl
from opentelemetry import context as context_api
from opentelemetry import trace
from opentelemetry.instrumentation.aiohttp_client.package import _instruments
Expand All @@ -108,7 +108,7 @@ def response_hook(span: Span, params: typing.Union[
from opentelemetry.trace.status import Status, StatusCode
from opentelemetry.util.http import remove_url_credentials

_UrlFilterT = typing.Optional[typing.Callable[[str], str]]
_UrlFilterT = typing.Optional[typing.Callable[[yarl.URL], str]]
owais marked this conversation as resolved.
Show resolved Hide resolved
_RequestHookT = typing.Optional[
typing.Callable[[Span, aiohttp.TraceRequestStartParams], None]
]
Expand Down