Tornado: Capture custom request/response headers as span attributes #950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashu658
changed the title
owais
approved these changes
Mar 9, 2022
srikanthccv
reviewed
Mar 9, 2022
.../opentelemetry-instrumentation-tornado/src/opentelemetry/instrumentation/tornado/__init__.py
Show resolved
Hide resolved
srikanthccv
approved these changes
Mar 9, 2022
auto-merge was automatically disabled
March 10, 2022 05:09
Head branch was pushed to by a user without write access
lzchen
approved these changes
Mar 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements the HTTP request/response headers as span attributes semantic convention for tornado framework.
Fixes #915
Type of change
How Has This Been Tested?
Added unit tests for the changes. Also, tested by capturing headers manually with tornado and observing the output on jaeger backend.
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.