Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"GET" function in propagators should return None if nothing is found #1274

Closed
lzchen opened this issue Oct 22, 2020 · 0 comments · Fixed by #1449
Closed

"GET" function in propagators should return None if nothing is found #1274

lzchen opened this issue Oct 22, 2020 · 0 comments · Fixed by #1449
Assignees
@lzchen
Labels
bug Something isn't working good first issue Good first issue release:required-for-ga To be resolved before GA release

Comments

@lzchen
Copy link
Contributor

lzchen commented Oct 22, 2020

Should be done after: #1196
Specs: https://github.com/open-telemetry/opentelemetry-specification/blob/master/specification/context/api-propagators.md#get
Conversation: #1196 (comment)
@lzchen lzchen added bug Something isn't working good first issue Good first issue release:required-for-ga To be resolved before GA release labels Oct 22, 2020
@lzchen lzchen mentioned this issue Oct 22, 2020
Merged
5 tasks
srikanthccv pushed a commit to srikanthccv/opentelemetry-python that referenced this issue Nov 1, 2020
@dyladan
fix: do not crash on fetch(new Request(url)) (open-telemetry#1274)
264fb36 
* fix: do not crash on fetch(new Request(url))

* chore: fix headers type
@lzchen lzchen self-assigned this Dec 4, 2020
This was referenced Dec 4, 2020
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lzchen lzchen

Labels
bug Something isn't working good first issue Good first issue release:required-for-ga To be resolved before GA release
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Return none for Getter if key does not exist lzchen/opentelemetry-python
2 participants
@codeboten @lzchen