Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update limits implementation to comply with the spec #2111

Closed
owais opened this issue Sep 14, 2021 · 0 comments · Fixed by #2139
Closed

Update limits implementation to comply with the spec #2111

owais opened this issue Sep 14, 2021 · 0 comments · Fixed by #2139
Labels
feature-request good first issue Good first issue help wanted specification

Comments

@owais
Copy link
Contributor

owais commented Sep 14, 2021

The spec was updated to prefer user defined global limits over model specific defaults in this PR: open-telemetry/opentelemetry-specification#1893 (comment)

We should review our limits implementation and update it if necessary.
owais added a commit to owais/opentelemetry-python that referenced this issue Sep 23, 2021
@owais
Add support for OTEL_ATTRIBUTE_COUNT_LIMIT
57edcc5 
Fixes open-telemetry#2055
Fixes open-telemetry#2111
@owais owais mentioned this issue Sep 23, 2021
Merged
11 tasks
owais added a commit to owais/opentelemetry-python that referenced this issue Sep 23, 2021
@owais
Add support for OTEL_ATTRIBUTE_COUNT_LIMIT
0a1a444 
Fixes open-telemetry#2055
Fixes open-telemetry#2111
owais added a commit to owais/opentelemetry-python that referenced this issue Sep 23, 2021
@owais
Add support for OTEL_ATTRIBUTE_COUNT_LIMIT
2991c12 
Fixes open-telemetry#2055
Fixes open-telemetry#2111
owais added a commit that referenced this issue Sep 25, 2021
@owais @srikanthccv
Add support for OTEL_ATTRIBUTE_COUNT_LIMIT (#2139)
e6d4b9c 
* Add support for OTEL_ATTRIBUTE_COUNT_LIMIT

Fixes #2055
Fixes #2111

* Update opentelemetry-sdk/src/opentelemetry/sdk/trace/__init__.py

Co-authored-by: Srikanth Chekuri <srikanth.chekuri92@gmail.com>

Co-authored-by: Srikanth Chekuri <srikanth.chekuri92@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature-request good first issue Good first issue help wanted specification
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add support for OTEL_ATTRIBUTE_COUNT_LIMIT owais/opentelemetry-python
1 participant
@owais