Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding BatchSpanProcessor thread name #2186

Conversation

benjaminsky
Copy link
Contributor

Description

Adding a name to the BatchSpanProcessor worker thread. This helps with debugging since this worker thread currently needs to live in the same process as the instrumented code.

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

This is covered by existing tests.

Does This PR Require a Contrib Repo Change?

  • No.

Checklist:

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@benjaminsky benjaminsky requested a review from a team October 8, 2021 21:56
@benjaminsky benjaminsky changed the title Adding thread name Adding BatchSpanProcessor thread name Oct 8, 2021
@benjaminsky
Copy link
Contributor Author

docker-test failed due to localhost:27017: [Errno 104] Connection reset by peer when connecting to mysql locally. This appears to be an intermittent failure. Is it possible to rerun this check?

@owais owais enabled auto-merge (squash) October 11, 2021 19:53
@ocelotl
Copy link
Contributor

ocelotl commented Oct 12, 2021

docker-test failed due to localhost:27017: [Errno 104] Connection reset by peer when connecting to mysql locally. This appears to be an intermittent failure. Is it possible to rerun this check?

Rerunning...

auto-merge was automatically disabled October 13, 2021 19:01

Head branch was pushed to by a user without write access

@benjaminsky benjaminsky force-pushed the bcampbell/BatchSpanProcessor_named_thread branch from a58973b to f937dc9 Compare October 13, 2021 19:01
@owais owais enabled auto-merge (squash) October 13, 2021 21:48
@owais owais merged commit e74e1f6 into open-telemetry:main Oct 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants