-
Notifications
You must be signed in to change notification settings - Fork 610
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
infra: accelerate builds #693
Conversation
this should reduce the build times for py38
Cool! I'd probably say the overhead of running pip multiple times is not a big issue (Python vm startup ~100ms, maybe an additional 100ms to load the core bytecode). But the lint re-order makes a lot of sense! Nice stuff. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approving assuming build will pass. Thanks!
tox.ini
Outdated
@@ -164,26 +160,16 @@ changedir = | |||
|
|||
commands_pre = | |||
; Install without -e to test the actual installation | |||
python -m pip install -U pip setuptools wheel | |||
|
|||
py3{4,5,6}: python -m pip install -U pip setuptools wheel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any reason why we still need this line if it is run in travis.yml
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately, upgrading pip in travis before bringing up virtualenvs via tox was part of a failed experiment. I've reverted the change in the travis file, and kept the pip install -U command for the versions of python that needed it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Some build time improvements: