Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove commented out test case #731

Merged
merged 3 commits into from
May 26, 2020
Merged

Remove commented out test case #731

merged 3 commits into from
May 26, 2020

Conversation

ocelotl
Copy link
Contributor

@ocelotl ocelotl commented May 25, 2020

Fixes #730

@ocelotl ocelotl requested a review from a team May 25, 2020 15:26
@ocelotl ocelotl self-assigned this May 25, 2020
codeboten
codeboten approved these changes May 25, 2020
View reviewed changes
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, if the issue won't be fixed in OC, it makes sense to remove the testcase for it. Thanks for getting to the bottom of the failure.

@codeboten codeboten merged commit b51a518 into open-telemetry:master May 26, 2020
srikanthccv pushed a commit to srikanthccv/opentelemetry-python that referenced this pull request Nov 1, 2020
@mayurkale22
Update Stackdriver exporter example (open-telemetry#731)
4e3c44d 
* Update Stackdriver exporter example

* fix: example lints
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codeboten codeboten codeboten approved these changes

@lzchen lzchen lzchen approved these changes

Assignees

@ocelotl ocelotl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Commented out test case
3 participants
@ocelotl @codeboten @lzchen