infra: adding step to publish action #733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding a step to test that uploading packages to pypi should work. This should prevent issues that occurred in the release of 0.7.0 from happening where a classifier was set incorrectly (3 - Beta), causing pypi to return a 400 and fail publishing packages.
owais
approved these changes
May 26, 2020
.github/workflows/publish.yml
Outdated
| TWINE_USERNAME: ${{ secrets.test_pypi_username }} | ||
| TWINE_PASSWORD: ${{ secrets.test_pypi_password }} | ||
| run: | | ||
| pip install twine |
There was a problem hiding this comment.
should installing deps/tools be an independent step before other steps that depend on it?
There was a problem hiding this comment.
Good point, done.
toumorokoshi
approved these changes
May 26, 2020
|
@toumorokoshi done! |
owais
approved these changes
May 26, 2020
lzchen
approved these changes
May 26, 2020
srikanthccv
pushed a commit
to srikanthccv/opentelemetry-python
that referenced
this pull request
Nov 1, 2020
* chore: add instruction for pg-pool plugin * chore: update NodeTracer to NodeTracerRegistry * chore: address comments Co-authored-by: Valentin Marchaud <thisismac47@gmail.com> Co-authored-by: Daniel Dyla <dyladan@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a step to test that uploading packages to pypi should work.
This should prevent issues that occurred in the release of 0.7.0 from happening where a classifier was set incorrectly (3 - Beta), causing pypi to return a 400 and fail publishing packages.