Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify documentation around adding attributes at span creation #1258

Closed
ahayworth opened this issue May 11, 2022 · 0 comments · Fixed by #1291
Closed

Clarify documentation around adding attributes at span creation #1258

ahayworth opened this issue May 11, 2022 · 0 comments · Fixed by #1291
Labels
spec-compliance/v1.10.0 spec-compliance Required for OpenTelemetry spec compliance

Comments

@ahayworth
Copy link
Contributor

Added in: open-telemetry/opentelemetry-specification#2383

I think our docs kinda say this today, so it would be a rather minor update on our end.
@ahayworth ahayworth added spec-compliance Required for OpenTelemetry spec compliance spec-compliance/v1.10.0 labels May 11, 2022
ahayworth added a commit that referenced this issue Jun 4, 2022
@ahayworth
docs: Add additional warning about attributes and span_creation
1fbdebb 
Fixes #1258 by noting that samplers only consider attributes present at span creation.
@ahayworth ahayworth mentioned this issue Jun 4, 2022
Merged
fbogsany added a commit that referenced this issue Jun 21, 2022
@ahayworth @fbogsany
docs: Add additional warning about attributes and span_creation (#1291)
5295423 
Fixes #1258 by noting that samplers only consider attributes present at span creation.

Co-authored-by: Francis Bogsanyi <francis.bogsanyi@shopify.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
spec-compliance/v1.10.0 spec-compliance Required for OpenTelemetry spec compliance
Projects
Ruby - Spec Compliance
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs: Add additional warning about attributes and span_creation open-telemetry/opentelemetry-ruby
1 participant
@ahayworth