fix! implement new Span.Status spec #411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fbogsany
requested review from
dazuma,
ericmustin,
mwear and
robertlaurin
as code owners
robertlaurin
approved these changes
Sep 21, 2020
mwear
approved these changes
Sep 21, 2020
There was a problem hiding this comment.
LGTM. We can and probably should set the error: true span attribute for the Jaeger exporter: https://github.com/open-telemetry/opentelemetry-ruby/blob/master/exporter/jaeger/lib/opentelemetry/exporter/jaeger/encoder.rb#L121-L124. This can be done in a follow up.
|
Updated to encode an error status in Jaeger, and to default to |
robertlaurin
approved these changes
Sep 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the new Span.Status spec: open-telemetry/opentelemetry-specification#966
We need the mapping to OTLP to be specified in order to complete this, however that is strictly additive and this implements the proposal for OK & Unset -> OK and Error -> UnknownError.