Skip to content

Commit

Permalink
Avoid using gRPC when generic RPC systems have same properties
Browse files Browse the repository at this point in the history
The concept of "streaming" is supported by multiple protocols including gRPC, but also others.

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
  • Loading branch information
bogdandrutu committed Sep 9, 2021
1 parent 7b0acc8 commit aa9c37b
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
8 changes: 4 additions & 4 deletions semantic_conventions/trace/rpc.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ groups:
- id: rpc
prefix: rpc
brief: 'This document defines semantic conventions for remote procedure calls.'
events: [rpc.grpc.message]
events: [rpc.message]
attributes:
- id: system
type: string
Expand Down Expand Up @@ -142,10 +142,10 @@ groups:
note: >
This is always required for jsonrpc. See the note in the general
RPC conventions for more information.
- id: rpc.grpc.message
prefix: "message" # TODO: Change the prefix to rpc.grpc.message?
- id: rpc.message
prefix: "message" # TODO: Change the prefix to rpc.message?
type: event
brief: "gRPC received/sent message."
brief: "RPC received/sent message."
attributes:
- id: type
type:
Expand Down
2 changes: 1 addition & 1 deletion specification/trace/semantic_conventions/rpc.md
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,7 @@ client and server spans.

The event name MUST be `"message"`.

<!-- semconv rpc.grpc.message -->
<!-- semconv rpc.message -->
| Attribute | Type | Description | Examples | Required |
|---|---|---|---|---|
| `message.type` | string | Whether this is a received or sent message. | `SENT` | No |
Expand Down

0 comments on commit aa9c37b

Please sign in to comment.