Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add category attribute to spans #1161

Open
justinfoote opened this issue Oct 30, 2020 · 2 comments
Open

Add category attribute to spans #1161

justinfoote opened this issue Oct 30, 2020 · 2 comments
Labels
area:semantic-conventions Related to semantic conventions priority:p3 Lowest priority level release:allowed-for-ga Editorial changes that can still be added before GA since they don't require action by SIGs spec:trace Related to the specification/trace directory

Comments

@justinfoote
Copy link
Member

What are you trying to achieve?

We have an implied span category -- that is, spans can be either database, faas, messaging, etc...
But at the moment, the only way to determine what category a span belongs to is by inspecting its attributes.

I'd like to see a span.category added to the semantic conventions for spans.
I would expect its value to be an enum of:

database
faas
http
messaging
rpc

I suggest that this field is optional in general, but should be required for any span that falls into one of these categories. It should be omitted for general spans with a Span.Kind of INTERNAL.

Additional context.

This came up in the discussion on PR 1142 here.

@justinfoote justinfoote added the spec:trace Related to the specification/trace directory label Oct 30, 2020
@justinfoote
Copy link
Member Author

@Oberon00

@Oberon00
Copy link
Member

Older related discussions:

@andrewhsu andrewhsu added area:semantic-conventions Related to semantic conventions priority:p3 Lowest priority level release:allowed-for-ga Editorial changes that can still be added before GA since they don't require action by SIGs labels Oct 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:semantic-conventions Related to semantic conventions priority:p3 Lowest priority level release:allowed-for-ga Editorial changes that can still be added before GA since they don't require action by SIGs spec:trace Related to the specification/trace directory
Projects
None yet
Development

No branches or pull requests

3 participants