Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do we still need component in semantic conventions? #271

Closed
yurishkuro opened this issue Sep 29, 2019 · 7 comments
Closed

Do we still need component in semantic conventions? #271

yurishkuro opened this issue Sep 29, 2019 · 7 comments
Labels
area:semantic-conventions Related to semantic conventions
Milestone

Comments

@yurishkuro
Copy link
Member

For example, in specification/data-semantic-conventions.md for HTTP

| component | Denotes the type of the span and needs to be "http". | Yes |

It's not clear what the value of this required attribute is given that the HTTP-nature of the span can be inferred from the other required attributes like http.method, so it only bloats the data size. Also, the OTEP 16 provides another mechanism for identifying the type of library/component.

@Oberon00
Copy link
Member

When going over the component attributes, it seems that the use of the component attribute is different for each convention:

  • gRPC: Component must be grpc, only way to detect gRPC, as the other attributes are the generic peer.*
  • db: Component is vaguely defined, but no fixed string at least (see Semantic convention for database driver name needed #245)
  • http: Seems redundant, as other required http.* attributes exist.

So maybe it was put there just for consistency?

BTW, in OTEP 16 (named tracers), you specify the name of the instrumenting library, not the instrumented library, so that's not really the use case.

@bogdandrutu
Copy link
Member

I think OTEP should use the name of the instrumented library not the name of the instrumentation.

@Oberon00
Copy link
Member

Oberon00 commented Oct 1, 2019

@bogdandrutu I think you are wrong (or I am misunderstanding your sentence):

The name used to create a Tracer or Meter must identify the instrumentation libraries (also referred to as integrations) and not the instrumented libraries.

-- https://github.com/open-telemetry/oteps/blob/master/text/0016-named-tracers.md#explanation

@pauldraper
Copy link

the HTTP-nature of the span can be inferred from the other required attributes like http.method

Much better to explicitly specify the component than try to guess based on other attributes. grpc is a good example, where it reuses the http attributes.

I would go a far as to say traces ought to always have component, as a quick way of seeing the instrumented technology.

@SergeyKanzhelev SergeyKanzhelev added the area:semantic-conventions Related to semantic conventions label Dec 3, 2019
@jmacd
Copy link
Contributor

jmacd commented Jan 22, 2020

This needs discussion in the next Spec SIG meeting.

@bogdandrutu
Copy link
Member

Discussed during the meeting to remove it.

arminru added a commit to dynatrace-oss-contrib/opentelemetry-specification that referenced this issue Jan 29, 2020
thisthat added a commit to dynatrace-oss-contrib/opentelemetry-specification that referenced this issue Jan 30, 2020
arminru added a commit to dynatrace-oss-contrib/opentelemetry-specification that referenced this issue Feb 7, 2020
arminru added a commit to dynatrace-oss-contrib/opentelemetry-specification that referenced this issue Feb 17, 2020
SergeyKanzhelev pushed a commit to SergeyKanzhelev/opentelemetry-specification that referenced this issue Feb 18, 2020
thisthat added a commit to dynatrace-oss-contrib/opentelemetry-specification that referenced this issue Feb 18, 2020
thisthat added a commit to dynatrace-oss-contrib/opentelemetry-specification that referenced this issue Feb 18, 2020
thisthat added a commit to dynatrace-oss-contrib/opentelemetry-specification that referenced this issue Mar 24, 2020
thisthat added a commit to dynatrace-oss-contrib/opentelemetry-specification that referenced this issue Mar 24, 2020
thisthat added a commit to dynatrace-oss-contrib/opentelemetry-specification that referenced this issue Apr 1, 2020
arminru added a commit to dynatrace-oss-contrib/opentelemetry-specification that referenced this issue Apr 7, 2020
thisthat added a commit to dynatrace-oss-contrib/opentelemetry-specification that referenced this issue Apr 7, 2020
TuckTuckFloof pushed a commit to TuckTuckFloof/opentelemetry-specification that referenced this issue Oct 15, 2020
@MatthewDolan
Copy link

Discussed during the meeting to remove it.

Is there a link to the recording or notes from the meeting? I am curious what factors were weighed in the decision.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:semantic-conventions Related to semantic conventions
Projects
None yet
Development

No branches or pull requests

8 participants