Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect statement about Views in OpenTelemetry Overview #4149

Closed
alfiejfs opened this issue Jul 16, 2024 · 3 comments · Fixed by #4150
Closed

Incorrect statement about Views in OpenTelemetry Overview #4149

alfiejfs opened this issue Jul 16, 2024 · 3 comments · Fixed by #4150
Labels
spec:metrics Related to the specification/metrics directory

Comments

@alfiejfs
Copy link
Contributor

The overview page has a section on views, where it is incorrectly stated that views can be applied through a Meter. I believe the wording is correct on the metrics SDK page view section where only MeterProvider is mentioned.

@alfiejfs alfiejfs added the spec:metrics Related to the specification/metrics directory label Jul 16, 2024
@MrAlias
Copy link
Contributor

MrAlias commented Jul 17, 2024

It is correct they are applied at the meter level. The instrument selection criteria allows for a view to be applied to an entire meter (name/version).

They are configured at the meter provider level.

The specification, as it is currently written is correct. I imagine the confusion comes from the last point about the view being configured at the meter provider level though. Updating the specification to clarify that point seems reasonable.

@alfiejfs
Copy link
Contributor Author

@MrAlias good spot! I agree - I think the wording is just slightly unclear. I will amend my PR.

@alfiejfs
Copy link
Contributor Author

Upon re-reading, I don't think it is necessary to specify that they can be applied globally or to specific meters at all then. This seems to specific to include in the overview. I think I might be a fan of just specifying that they can be configured through the MeterProvider.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
spec:metrics Related to the specification/metrics directory
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants