Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect assertion about views and meter in overview #4150

Merged
merged 2 commits into from
Jul 19, 2024
Merged

Fix incorrect assertion about views and meter in overview #4150

merged 2 commits into from
Jul 19, 2024

Conversation

alfiejfs
Copy link
Contributor

Changes

Fixes #4149, fixing an incorrect statement about being able to apply a View to a Meter.

@alfiejfs alfiejfs requested review from a team July 16, 2024 22:47
@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Jul 16, 2024 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@reyang
Copy link
Member

reyang commented Jul 16, 2024

Thanks @alfiejfs! Would you clear the CLA? #4150 (comment)

@arminru arminru merged commit 32bad98 into open-telemetry:main Jul 19, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrAlias MrAlias MrAlias approved these changes

@arminru arminru arminru approved these changes

@reyang reyang reyang approved these changes

@jack-berg jack-berg jack-berg approved these changes

Assignees

@yurishkuro yurishkuro

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect statement about Views in OpenTelemetry Overview
6 participants
@alfiejfs @reyang @MrAlias @arminru @jack-berg @yurishkuro