Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Define the log error translation for the OT Shim layer. #1563

Merged
merged 3 commits into from
Mar 19, 2021
Merged

Define the log error translation for the OT Shim layer. #1563

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fa61235
Define the log error translation for the OT Shim layer.
carlosalberto Mar 19, 2021
9628851
Fix link.
carlosalberto Mar 19, 2021
9c624f1
Merge branch 'main' into ot_error_log_translation
carlosalberto Mar 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions specification/compatibility/opentracing.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -264,6 +264,21 @@ key/value pair set.
The `Add Event`'s `name` parameter MUST be the value with the `event` key in
the pair set, or else fallback to use the `log` literal string.

If pair set contains a `event=error` entry, the values MUST be mapped from
[OpenTracing Log Fields](https://github.com/opentracing/specification/blob/master/semantic_conventionsmd#log-fields-table)
to an `Event` with the conventions outlined in the
[Exception semantic conventions](../trace/semantic_conventions/exceptions.md) document:

- If an entry with `error.object` key exists and the value is a language-specific
error object, a call to `RecordException(e)` is performed along the rest of
the specified key/value pair set as additional event attributes.
- Else, a call to `AddEvent` is performed with `name` being set to `exception`,
along the specified key/value pair set as additional event attributes,
including mapping of the following key/value pairs:
- `error.kind` maps to `exception.type`.
- `message` maps to `exception.message`.
- `stack` maps to `exception.stacktrace`.

If an explicit timestamp is specified, a conversion MUST be done to match the
OpenTracing and OpenTelemetry units.

Expand Down