Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Sum description in data model specification #1618

Merged
merged 17 commits into from
Apr 29, 2021
Merged

Add Sum description in data model specification #1618

merged 17 commits into from
Apr 29, 2021

Conversation

jsuereth
Copy link
Contributor

Fixes #1566

Changes

  • Adds specification details around "Sum" and the semantics encoding in OTLP for sum
  • Clarifies "OTLP => Timeseries" mapping for Sum, Gauge + Histogram
  • Make sure "Summary" is described as legacy support
  • Outline algorithm for Delta=>Cumulative transformation, including limitations for accuracy.

@jsuereth jsuereth requested review from a team April 15, 2021 17:01
@jsuereth @sirianni
Update specification/metrics/datamodel.md
59145fa 
Co-authored-by: Eric Sirianni <sirianni@users.noreply.github.com>
punya
punya reviewed Apr 15, 2021
View reviewed changes
specification/metrics/datamodel.md Outdated Show resolved Hide resolved
specification/metrics/datamodel.md Outdated Show resolved Hide resolved
specification/metrics/datamodel.md Outdated Show resolved Hide resolved
specification/metrics/datamodel.md Outdated Show resolved Hide resolved
specification/metrics/datamodel.md Show resolved Hide resolved
specification/metrics/datamodel.md Show resolved Hide resolved
jsuereth and others added 2 commits April 15, 2021 14:22
@jsuereth @punya
Update specification/metrics/datamodel.md
62a611e 
Co-authored-by: Punya Biswal <punya@google.com>
@jsuereth @punya
Update specification/metrics/datamodel.md
884330a 
Co-authored-by: Punya Biswal <punya@google.com>
jmacd
jmacd approved these changes Apr 19, 2021
View reviewed changes
specification/metrics/datamodel.md Outdated Show resolved Hide resolved
specification/metrics/datamodel.md Outdated Show resolved Hide resolved
specification/metrics/datamodel.md Outdated Show resolved Hide resolved
specification/metrics/datamodel.md Outdated Show resolved Hide resolved
reyang
reyang approved these changes Apr 20, 2021
View reviewed changes
Copy link
Member

@reyang reyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@jmacd jmacd mentioned this pull request Apr 22, 2021
Merged
@jmacd
Copy link
Contributor

jmacd commented Apr 22, 2021

@open-telemetry/specs-metrics-approvers please take a look.

jmacd
jmacd approved these changes Apr 26, 2021
View reviewed changes
specification/metrics/datamodel.md Show resolved Hide resolved
@jmacd jmacd mentioned this pull request Apr 27, 2021
Closed
@jsuereth jsuereth mentioned this pull request Apr 27, 2021
Open
@jsuereth
Copy link
Contributor Author

@jmacd This should be ready to go now.

@jmacd jmacd merged commit a4b08e2 into open-telemetry:main Apr 29, 2021
@jsuereth jsuereth deleted the wip-delta-to-cumulative branch April 29, 2021 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@punya punya punya left review comments

@sirianni sirianni sirianni left review comments

@jack-berg jack-berg jack-berg left review comments

@bogdandrutu bogdandrutu bogdandrutu approved these changes

@jmacd jmacd jmacd approved these changes

@reyang reyang reyang approved these changes

@victlu victlu victlu approved these changes

Assignees

@jmacd jmacd

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

How to rebuild from deltas?
8 participants
@jsuereth @jmacd @punya @sirianni @bogdandrutu @reyang @jack-berg @victlu