Add details to Asynchronous UpDownCounter API #1704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reyang
added
area:api
jsuereth
reviewed
May 15, 2021
| UpDownCounter. To determine the reported rate the Asynchronous UpDownCounter is | ||
| changing, the difference between successive measurements is used. | ||
|
|
||
| The callback function SHOULD NOT take indefinite amount of time. If multiple |
There was a problem hiding this comment.
similar question on # of exporters per-sdk
There was a problem hiding this comment.
Tracked by the discussion here #1703 (comment).
There was a problem hiding this comment.
I think the collection cycle suggestion from the thread is great and making this note would be beneficial for the spec. Is there work item to track this ? I don't think we need to block this PR.
jsuereth
approved these changes
May 15, 2021
jmacd
approved these changes
May 19, 2021
weyert
approved these changes
May 20, 2021
Aneurysm9
approved these changes
May 20, 2021
SergeyKanzhelev
approved these changes
May 21, 2021
|
enough approvals, cool off period passed, merging. @reyang would you please address the comment about the number of calls to the callback per collection comment? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up #1617.
Changes
Added details to the Asynchronous Gauge instrument. In #1617 these were left as TODO.