Lambda instrumentations should check if X-Ray parent context is valid #1867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@anuraaga would appreciate your review on this PR! |
anuraaga
approved these changes
Aug 14, 2021
carlosalberto
approved these changes
Aug 16, 2021
|
@NathanielRN Maybe this is enough of a change to deserve a CHANGELOG? Or think it's not really needed for this change? |
NathanielRN
changed the title
|
@carlosalberto Originally I didn't think it was necessary, but I guess it's safer to add it so that devs instrumenting Lambda know that they have an action item to do 😄 I've added a CHANGELOG entry! |
NathanielRN
force-pushed
the
update-x-ray-context-parenting
branch
from
a4adffa
to
af2735b
Compare
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
The behavior of Lambda requires that we check that the context
IsValidin addition to checking if it sampled. We update the specs to reflect that.Also changed the wording in the API Gateway section so that we know that the attributes are set in both the "as a pure proxy" and "as a configuration for a REST API" setups of API Gateway.