Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AWS App Runner as a cloud platform #2004

Merged
merged 6 commits into from
Oct 15, 2021

Conversation

willarmiros
Copy link
Contributor

@willarmiros willarmiros commented Oct 8, 2021

Changes

Adds AWS App Runner as an allow-listed cloud platform. As a follow up, a resource detector will be added to the collector to record that it is operating in the app runner environment.

Please let me know if anything else is necessary to make this change properly.

@arminru arminru added area:semantic-conventions Related to semantic conventions spec:resource Related to the specification/resource directory labels Oct 11, 2021
Copy link
Contributor

@iNikem iNikem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@willarmiros please update CHANGELOG.md as well

@willarmiros
Copy link
Contributor Author

@iNikem done!

@willarmiros
Copy link
Contributor Author

@jmacd @arminru @iNikem @carlosalberto any chance of merging this in?

@arminru arminru changed the title add AWS App Runner as a cloud platform Add AWS App Runner as a cloud platform Oct 15, 2021
@arminru arminru merged commit 195f760 into open-telemetry:main Oct 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:semantic-conventions Related to semantic conventions spec:resource Related to the specification/resource directory
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants