-
Notifications
You must be signed in to change notification settings - Fork 887
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial Prometheus <-> OTLP datamodel specification. #2266
Conversation
cbd0b2b
to
2283530
Compare
ef6c6e3
to
9321203
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: Prometheus should be consistently capitalized.
Done |
4c7ae2a
to
fd49478
Compare
@dashpole not sure if prometheus let users set their "job" in the metrics source, but if that is the case probably the library sdk prom exporter should convert "service.name" to "job". Also a separate PR is fine. |
It is possible to set "job" in the metrics source, but by default it will be overwritten by service discovery. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The conversions statements here are not made using the normative language conventions this specification is defined to use. Can we update these statements to make clear requirements and recommendations about these conversions?
Done. |
879f489
to
aaf9295
Compare
7893938
to
98b28b8
Compare
This looks like it's ready to go. Please confirm there's no blocker at this moment @brian-brazil @legendecas @anuraaga @jmacd |
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
Co-authored-by: legendecas <legendecas@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍nice works!
Co-authored-by: Joshua MacDonald <jmacd@users.noreply.github.com>
This supersedes #2017, and is meant to capture the current state of prometheus support in prometheus SDK exporters and prometheus collector receivers/exporters, rather than the desired end state. This is done to avoid (potentially) contentious debates in the initial draft, and allow tackling these topics individually.
There are a number of changes we will likely want to make after this: