Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add draft logging library SDK specification #2328

Merged
merged 4 commits into from
Feb 17, 2022

Conversation

tigrannajaryan
Copy link
Member

@tigrannajaryan tigrannajaryan commented Feb 9, 2022

This is the first cut from the OTEP0150
This a draft that requires cleanup and clarifications that will be done in follow-up PR.

This PR primarily copies the OTEP0150 content, minus sections which are typically
only present in OTEPS (Motivation, Alternates, Future Possibilities, etc).

specification/logs/logging-library-sdk.md Outdated Show resolved Hide resolved
specification/logs/logging-library-sdk.md Show resolved Hide resolved
specification/logs/logging-library-sdk.md Outdated Show resolved Hide resolved
specification/logs/logging-library-sdk.md Show resolved Hide resolved
Copy link
Member

@reyang reyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with some minor suggestions.

@tigrannajaryan
Copy link
Member Author

@open-telemetry/specs-logs-approvers please review.

@tigrannajaryan
Copy link
Member Author

@zenmoto @kumoroku please review.

This is the first cut from the [OTEP0150](https://github.com/open-telemetry/oteps/blob/main/text/logs/0150-logging-library-sdk.md)
This a draft that requires cleanup and clarifications that will be done in follow-up PR.

This PR primarily copies the OTEP0150 content, minus sections which are typically
only present in OTEPS (Motivaiton, Alternates, Future Possibilities, etc).
@tigrannajaryan
Copy link
Member Author

We have enough approvals. I think the draft is good to merge. It is not the final form anyway, we will need to work on this doc.

@tigrannajaryan tigrannajaryan merged commit 560e5a8 into open-telemetry:main Feb 17, 2022
@tigrannajaryan tigrannajaryan deleted the add-loglib-sdk branch February 17, 2022 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants