Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure Jaeger exporter SDK env var section #2365

Merged

Conversation

pellared
Copy link
Member

@pellared pellared commented Feb 18, 2022

Fixes #2357

Changes

Restructure Jaeger exporter section so that it should be a more readable (from both markdown and "rendered version" perspective).

Preview here

Alternatives

I was trying to adopt the approach from #2345, however:

  1. It was hard to fit into the current document structure. It looked awkward when compared to other sections in the same document.
  2. I found it less readable.
  3. This section is less frequently changing than the OTLP exporter equivalent.

@carlosalberto
Copy link
Contributor

Ping @yurishkuro ;)

specification/sdk-environment-variables.md Outdated Show resolved Hide resolved
@carlosalberto carlosalberto merged commit d6bcc0c into open-telemetry:main Mar 10, 2022
@pellared pellared deleted the refactor-jaeger-exporter-env-vars branch March 10, 2022 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Restructure Jaeger exporter section in SDK configuration doc
4 participants