Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify MetricReader.Collect result #2495

Merged
merged 5 commits into from
Apr 21, 2022

Conversation

legendecas
Copy link
Member

Fixes #2295

Changes

  • Add statements on MetricReader.Collect that it should provide better availability when partial errors occur.

@legendecas legendecas marked this pull request as ready for review April 18, 2022 09:37
@legendecas legendecas requested review from a team April 18, 2022 09:37
Copy link
Member

@reyang reyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@reyang reyang added spec:metrics Related to the specification/metrics directory area:sdk Related to the SDK labels Apr 19, 2022
Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
@reyang reyang merged commit 93ebea0 into open-telemetry:main Apr 21, 2022
@legendecas legendecas deleted the metrics-async-timeout branch April 21, 2022 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:sdk Related to the SDK spec:metrics Related to the specification/metrics directory
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clarify MetricReader collect result
5 participants