Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify async instrument callback identity #2538

Merged
merged 9 commits into from
Jul 12, 2022

Conversation

legendecas
Copy link
Member

@legendecas legendecas commented May 13, 2022

Fixes #2408

Changes

Callbacks registered after the time of instrument creation MAY be associated with multiple instruments.

  • Clarify the identity of the statement "one callback associated with an instrument MUST be evaluated exactly once".

@reyang reyang added spec:metrics Related to the specification/metrics directory area:sdk Related to the SDK area:api Cross language API specification issue and removed area:sdk Related to the SDK labels May 13, 2022
@reyang
Copy link
Member

reyang commented May 19, 2022

@jmacd @jsuereth need your help to review this PR, thanks!

@github-actions
Copy link

github-actions bot commented Jun 2, 2022

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions bot added the Stale label Jun 2, 2022
@github-actions
Copy link

Closed as inactive. Feel free to reopen if this PR is still being worked on.

@github-actions github-actions bot closed this Jun 10, 2022
# Conflicts:
#	specification/metrics/api.md
@legendecas
Copy link
Member Author

@open-telemetry/specs-metrics-approvers this PR is still valid but I don't have the permission to re-open it. I'd appreciate it if anyone could help me to reopen it. Thank you <3.

@jack-berg jack-berg reopened this Jun 10, 2022
@github-actions github-actions bot removed the Stale label Jun 11, 2022
@github-actions
Copy link

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions bot added the Stale label Jun 18, 2022
@legendecas
Copy link
Member Author

@jmacd @jsuereth would you mind taking a look at this again? thank you!

@github-actions
Copy link

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions bot added the Stale label Jul 12, 2022
@legendecas
Copy link
Member Author

this is not stale.

@jmacd @jsuereth would you mind taking a look at this again? thank you!

@jmacd jmacd merged commit 8f7cdb7 into open-telemetry:main Jul 12, 2022
@legendecas legendecas deleted the metric-callback branch July 13, 2022 00:47
beeme1mr pushed a commit to beeme1mr/opentelemetry-specification that referenced this pull request Aug 31, 2022
* Clarify async instrument callback identity

* fixup!

* fixup!

Co-authored-by: Joshua MacDonald <jmacd@users.noreply.github.com>
beeme1mr pushed a commit to beeme1mr/opentelemetry-specification that referenced this pull request Aug 31, 2022
* Clarify async instrument callback identity

* fixup!

* fixup!

Co-authored-by: Joshua MacDonald <jmacd@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:api Cross language API specification issue spec:metrics Related to the specification/metrics directory Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clarify how should SDK invokes async instrument callbacks
6 participants