Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance semantic conventions for HTTP #263

Merged
merged 38 commits into from
Oct 28, 2019
Merged

Enhance semantic conventions for HTTP #263

merged 38 commits into from
Oct 28, 2019

Commits on Sep 27, 2019

  1. Update HTTP conventions.

    @Oberon00
    Oberon00 committed Sep 27, 2019
    Configuration menu
    Copy the full SHA
    dee825c View commit details
    Browse the repository at this point in the history

  2. Improve HTTP, fix references to peer.*.

    @Oberon00
    Oberon00 committed Sep 27, 2019
    Configuration menu
    Copy the full SHA
    6d4ed7f View commit details
    Browse the repository at this point in the history

  3. Wording.

    @Oberon00
    Oberon00 committed Sep 27, 2019
    Configuration menu
    Copy the full SHA
    b894d0b View commit details
    Browse the repository at this point in the history

  4. typo a/an http

    @Oberon00
    Oberon00 committed Sep 27, 2019
    Configuration menu
    Copy the full SHA
    5621102 View commit details
    Browse the repository at this point in the history

  5. host.name/host.port

    @Oberon00
    Oberon00 committed Sep 27, 2019
    Configuration menu
    Copy the full SHA
    417f488 View commit details
    Browse the repository at this point in the history

  6. Clarify server_name.

    @Oberon00
    Oberon00 committed Sep 27, 2019
    Configuration menu
    Copy the full SHA
    b6e79ba View commit details
    Browse the repository at this point in the history

  7. Typo, missing 'has'.

    @Oberon00
    Oberon00 committed Sep 27, 2019
    Configuration menu
    Copy the full SHA
    a452423 View commit details
    Browse the repository at this point in the history

  8. Typo nginx link.

    @Oberon00
    Oberon00 committed Sep 27, 2019
    Configuration menu
    Copy the full SHA
    ab163c9 View commit details
    Browse the repository at this point in the history

  9. Wording.

    @Oberon00
    Oberon00 committed Sep 27, 2019
    Configuration menu
    Copy the full SHA
    6be7dc1 View commit details
    Browse the repository at this point in the history

Commits on Sep 28, 2019

  1. Typo in span name convention. 

    Co-Authored-By: Tigran Najaryan <4194920+tigrannajaryan@users.noreply.github.com>
    @Oberon00 @tigrannajaryan
    Oberon00 and tigrannajaryan committed Sep 28, 2019
    Configuration menu
    Copy the full SHA
    af08156 View commit details
    Browse the repository at this point in the history

Commits on Sep 30, 2019

  1. Wording for common HTTP intro. 

    In response to @SergeyKanzhelev
(open-telemetry#263 (comment)).
    @Oberon00
    Oberon00 committed Sep 30, 2019
    Configuration menu
    Copy the full SHA
    d362e39 View commit details
    Browse the repository at this point in the history

  2. Make http.flavor non-required. 

    In-reply-to: open-telemetry#263 (comment)

Co-authored-by: Sergey Kanzhelev <S.Kanzhelev@live.com>
    @Oberon00 @SergeyKanzhelev
    Oberon00 and SergeyKanzhelev committed Sep 30, 2019
    Configuration menu
    Copy the full SHA
    f4d69c2 View commit details
    Browse the repository at this point in the history

  3. Clarify client's http.url. 

    In-reply-to: open-telemetry#263 (comment)
    @Oberon00
    Oberon00 committed Sep 30, 2019
    Configuration menu
    Copy the full SHA
    673635c View commit details
    Browse the repository at this point in the history

  4. HTTP server span name: reference http.app_root. 

    In-reply-to: open-telemetry#263 (comment)
    @Oberon00
    Oberon00 committed Sep 30, 2019
    Configuration menu
    Copy the full SHA
    471aca3 View commit details
    Browse the repository at this point in the history

  5. Split "Definitions" from conventions, clarify app_root. 

    In-reply-to: open-telemetry#263 (comment)
    @Oberon00
    Oberon00 committed Sep 30, 2019
    Configuration menu
    Copy the full SHA
    62361d2 View commit details
    Browse the repository at this point in the history

  6. Qualify order of http server attr preferences. 

    In-reply-to: open-telemetry#263 (comment)
    @Oberon00
    Oberon00 committed Sep 30, 2019
    Configuration menu
    Copy the full SHA
    6ab5dc9 View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2019

  1. Address review comments.

    @Oberon00
    Oberon00 committed Oct 2, 2019
    Configuration menu
    Copy the full SHA
    1f796f3 View commit details
    Browse the repository at this point in the history

  2. Typo.

    @Oberon00
    Oberon00 committed Oct 2, 2019
    Configuration menu
    Copy the full SHA
    a9341a9 View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2019

  1. Make http.status_code conditionally required.

    @Oberon00
    Oberon00 committed Oct 4, 2019
    Configuration menu
    Copy the full SHA
    62a326c View commit details
    Browse the repository at this point in the history

  2. Move http.host,target,scheme; clarify empty host.

    @Oberon00
    Oberon00 committed Oct 4, 2019
    Configuration menu
    Copy the full SHA
    868eaf7 View commit details
    Browse the repository at this point in the history

  3. Fix misplaced paragraph.

    @Oberon00
    Oberon00 committed Oct 4, 2019
    Configuration menu
    Copy the full SHA
    474ebaf View commit details
    Browse the repository at this point in the history

  4. Fix client host/port requirement.

    @Oberon00
    Oberon00 committed Oct 4, 2019
    Configuration menu
    Copy the full SHA
    8699757 View commit details
    Browse the repository at this point in the history

Commits on Oct 7, 2019

  1. Fix HTTP status code OC incompat annotations.

    @Oberon00
    Oberon00 committed Oct 7, 2019
    Configuration menu
    Copy the full SHA
    fd56d2c View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into httpconv

    @Oberon00
    Oberon00 committed Oct 7, 2019
    Configuration menu
    Copy the full SHA
    7355684 View commit details
    Browse the repository at this point in the history

Commits on Oct 15, 2019

  1. Merge branch 'master' into httpconv

    @SergeyKanzhelev
    SergeyKanzhelev committed Oct 15, 2019
    Configuration menu
    Copy the full SHA
    e8d4b81 View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2019

  1. Fix incomplete sentence.

    @Oberon00
    Oberon00 committed Oct 16, 2019
    Configuration menu
    Copy the full SHA
    fcdaead View commit details
    Browse the repository at this point in the history

  2. Markdown syntax.

    @Oberon00
    Oberon00 committed Oct 16, 2019
    Configuration menu
    Copy the full SHA
    b51463f View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2019

  1. Update HTTP example (remove URL, add client). 

    In-reply-to: open-telemetry#263 (comment)
    @Oberon00
    Oberon00 committed Oct 21, 2019
    Configuration menu
    Copy the full SHA
    119509e View commit details
    Browse the repository at this point in the history

Commits on Oct 23, 2019

  1. Merge branch 'master' into httpconv

    @Oberon00
    Oberon00 committed Oct 23, 2019
    Configuration menu
    Copy the full SHA
    5f5c4b6 View commit details
    Browse the repository at this point in the history

  2. Fix markdownlint.

    @Oberon00
    Oberon00 committed Oct 23, 2019
    Configuration menu
    Copy the full SHA
    a432832 View commit details
    Browse the repository at this point in the history

  3. Typo.

    @Oberon00
    Oberon00 committed Oct 23, 2019
    Configuration menu
    Copy the full SHA
    291ba38 View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2019

  1. Remove http.app Span attribute. 

    In-reply-to: open-telemetry#263 (comment)
In-reply-to: open-telemetry#263 (comment)
    @Oberon00
    Oberon00 committed Oct 24, 2019
    Configuration menu
    Copy the full SHA
    9364357 View commit details
    Browse the repository at this point in the history

  2. Fix lint. 

    ./specification/data-semantic-conventions.md:155: MD036 Emphasis used instead of a header
    @Oberon00
    Oberon00 committed Oct 24, 2019
    Configuration menu
    Copy the full SHA
    280bd01 View commit details
    Browse the repository at this point in the history

Commits on Oct 26, 2019

  1. Merge branch 'master' into httpconv

    @SergeyKanzhelev
    SergeyKanzhelev committed Oct 26, 2019
    Configuration menu
    Copy the full SHA
    c59d280 View commit details
    Browse the repository at this point in the history

Commits on Oct 28, 2019

  1. Add note about n:1 server_name + app_root => app.

    @Oberon00
    Oberon00 committed Oct 28, 2019
    Configuration menu
    Copy the full SHA
    8a25ef4 View commit details
    Browse the repository at this point in the history

  2. Typo.

    @Oberon00
    Oberon00 committed Oct 28, 2019
    Configuration menu
    Copy the full SHA
    3f055cb View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into httpconv

    @SergeyKanzhelev
    SergeyKanzhelev committed Oct 28, 2019
    Configuration menu
    Copy the full SHA
    2e5c5eb View commit details
    Browse the repository at this point in the history

  4. Remove http.app_root. (#4) 

    In-reply-to: open-telemetry#263 (comment)
    @Oberon00
    Oberon00 committed Oct 28, 2019
    Configuration menu
    Copy the full SHA
    a8685ca View commit details
    Browse the repository at this point in the history