Make clear that context is not mutable when setting a span #2637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not at all tied to the wording changes. Would very much appreciate feedback from more familiar folks |
yurishkuro
reviewed
Jun 30, 2022
yurishkuro
approved these changes
Jul 1, 2022
arminru
added
area:api
arminru
approved these changes
Jul 5, 2022
carlosalberto
approved these changes
Jul 5, 2022
beeme1mr
pushed a commit
to beeme1mr/opentelemetry-specification
that referenced
this pull request
Aug 31, 2022
…metry#2637) * Make clear that context is not mutable when setting a span * Avoid making the copy seem mutable * Update the summary line to also not sound like Context is mutable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2624
Changes
Tries to clarify the sentence to make it clear that setting a span should not mutate the current context.
Related issues #
Related OTEP(s) #