Drop spec matrix support of Java Thrift HTTP #2659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mateuszrzeszutek
approved these changes
Jul 12, 2022
arminru
approved these changes
Jul 12, 2022
reyang
approved these changes
Jul 13, 2022
|
Not sure this should have been merged. I think this PR was in response to this comment, but that the comment was actually describing removing this entire line from the spec compliance table, rather than just switching the java column from |
@jack-berg You're right, it was in response to that comment...so I guess I misunderstood the intended scope. I will follow up with another PR that removes the line completely and we can chat about it there. Thanks for pointing this out! 👍🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is related to an issue in the java sdk concerning removal of Java's Thrift+HTTP support for Jaeger.
The current Java Thrift+HTTP Jaeger exporter is built on top of the jaeger-client java library, which has recently been deprecated.
The existing exporter really only depends on the Jaeger client library to get the autogenerated Thrift classes. One could make the case that the java exporter could source the IDL itself directly from
jaegertracingand autogenerate the classes at build time. That's definitely a possibility; however, I will make the case that reducing options will make for a clearer user experience. By dropping support, I think we also put forth a recommendation that is consistent with jaeger's messaging which now saysThe docs site also claims native support for OTLP from the otel SDKs. This gives users a clear path forward without depending on the Thrift HTTP exporter.
Once we get spec support of this, we can begin the process of deprecating the exporter in the java sdk.